feat(vm): implement EIP-7823#6551
Closed
ouy95917 wants to merge 5 commits intotronprotocol:developfrom
Closed
Conversation
ouy95917
force-pushed
the
implement-eip-7823
branch
from
ada39b9 to
8dd8e7d
Compare
bladehan1
reviewed
Mar 2, 2026
| return Optional.ofNullable(getUnchecked(ALLOW_TVM_OSAKA)) | ||
| .map(BytesCapsule::getData) | ||
| .map(ByteArray::toLong) | ||
| .orElse(0L); |
Contributor
There was a problem hiding this comment.
The ability to read from the configuration file needs to be retained for testing purposes.
# Conflicts: # common/src/main/java/org/tron/core/Constant.java # framework/src/main/java/org/tron/core/config/args/Args.java
1. Change ALLOW_TVM_OSAKA proposal id from 95 to 96 2. DynamicPropertiesStore.getAllowTvmOsaka() defaults to CommonParameter 3. ModExp returns Pair.of(false, EMPTY_BYTE_ARRAY) instead of throwing PrecompiledContractException when inputs exceed 1024 bytes, matching geth/besu behavior where only the CALL fails (not the whole tx) 4. Update test to verify return value instead of catching exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce
EIP-7823into TVM, and for this purpose, theallowTvmOsakaproposal has been added.